Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api!: remove hostname dependency #66

Merged
merged 1 commit into from
Dec 3, 2024
Merged

api!: remove hostname dependency #66

merged 1 commit into from
Dec 3, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Dec 3, 2024

This change removes ClientId::hostname().
If someone wants to send the hostname,
they have to configure it manually.

For clients default value "[127.0.0.1]"
is a better default as it does
not leak local hostname
and it works successfully
both in Delta Chat and TorBirdy for years.

This change removes `ClientId::hostname()`.
If someone wants to send the hostname,
they have to configure it manually.

For clients default value "[127.0.0.1]"
is a better default as it does
not leak local hostname
and it works successfully
both in Delta Chat and TorBirdy for years.
@link2xt link2xt merged commit 9f70067 into master Dec 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant